From 1bd28a2b6d196669d58b0c7e579928eb1d7f512f Mon Sep 17 00:00:00 2001 From: GameHerobrine Date: Sun, 20 Aug 2023 03:55:48 +0300 Subject: [PATCH] /ach rewrite --- src/API/AchievementAPI.php | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/src/API/AchievementAPI.php b/src/API/AchievementAPI.php index ee1d87a2..b81a2549 100644 --- a/src/API/AchievementAPI.php +++ b/src/API/AchievementAPI.php @@ -159,23 +159,21 @@ class AchievementAPI{ public function viewAchievements($cmd, $params, $issuer, $alias) { - if(!($issuer instanceof Player) && !isset($params[0])){ - return "Please enter a nickname."; - } else{ - if(! ($issuer instanceof Player) || (isset($params[0]) && $this->server->api->ban->isOp($issuer->username))){ - $player = $this->server->api->player->get($params[0]); - if($player instanceof Player){ - $data = $player->data; - } else{ - $data = $this->server->api->player->getOffline(trim($params[0]), false); - } - } else{ + if(!isset($params[0])){ + if(!($issuer instanceof Player)){ + return "Please enter a nickname."; + }else{ $data = $issuer->achievements; } + }else if(!($issuer instanceof Player) || $this->server->api->ban->isOp($issuer->iusername)){ + $player = $this->server->api->player->get($params[0]); + $data = $player instanceof Player ? $player->data : $this->server->api->player->getOffline(trim($params[0]), false); } - if($data === false){ - return "Player {$params[0]} is not found."; + + if(!$data){ + return "Player is not found."; } + if($data instanceof Config){ $achs = $data->get("achievements"); }else{