Unnecessary arguments in the if expression

This commit is contained in:
Sunch 2024-08-17 19:58:16 +08:00
parent f9f4e65571
commit 4630481d54
9 changed files with 13 additions and 13 deletions

View file

@ -130,7 +130,7 @@ class AchievementAPI{
return false;
}
if(!isset($player->achievements[$achievementId]) or $player->achievements[$achievementId] == false){
if(!isset($player->achievements[$achievementId]) or !$player->achievements[$achievementId]){
return false;
}
return true;
@ -140,7 +140,7 @@ class AchievementAPI{
if(isset(self::$achievements[$achievementId])){
$result = ServerAPI::request()->api->dhandle("achievement.broadcast", ["player" => $player, "achievementId" => $achievementId]);
if($result !== false and $result !== true){
if(ServerAPI::request()->api->getProperty("announce-player-achievements") == true){
if(ServerAPI::request()->api->getProperty("announce-player-achievements")){
ServerAPI::request()->api->chat->broadcast($player->username . " has just earned the achievement [" . self::$achievements[$achievementId]["name"] . "]");
}else{
$player->sendChat("You have just earned the achievement [" . self::$achievements[$achievementId]["name"] . "]");

View file

@ -152,7 +152,7 @@ class ServerAPI{
//define("MAX_CHUNK_RATE", 20 / $this->getProperty("max-chunks-per-second", 8)); //Default rate ~512 kB/s
MobSpawner::$spawnAnimals = $this->getProperty("spawn-animals");
MobSpawner::$spawnMobs = $this->getProperty("spawn-mobs");
if($this->getProperty("upnp-forwarding") == true){
if($this->getProperty("upnp-forwarding")){
console("[INFO] [UPnP] Trying to port forward...");
UPnP_PortForward($this->getProperty("server-port"));
}
@ -245,7 +245,7 @@ class ServerAPI{
public function setProperty($name, $value, $save = true){
$this->config->set($name, $value);
if($save == true){
if($save){
$this->writeProperties();
}
$this->loadProperties();