mirror of
https://github.com/oldminecraftcommunity/NostalgiaCore.git
synced 2026-11-20 11:39:43 +00:00
fixed server crash using invalid nbt, fixed playerinputpacket and setentitylinkpacket being handled if the player did not spawn
This commit is contained in:
parent
7166d58916
commit
55efde1f5c
3 changed files with 81 additions and 6 deletions
|
|
@ -3275,23 +3275,27 @@ class Player{
|
|||
$t->spawn($this);
|
||||
}else{
|
||||
$nbt = new NBT();
|
||||
$nbt->load($packet->namedtag);
|
||||
$d = array_shift($nbt->tree);
|
||||
if($d["id"] !== TILE_SIGN){
|
||||
$d = $nbt->loadSignNBT($packet->namedtag);
|
||||
if($d === false){
|
||||
$t->spawn($this);
|
||||
}else{
|
||||
|
||||
$t->setText($d["Text1"], $d["Text2"], $d["Text3"], $d["Text4"]);
|
||||
}
|
||||
}
|
||||
}
|
||||
break;
|
||||
case ProtocolInfo::SET_ENTITY_LINK_PACKET:
|
||||
if($this->spawned === false){
|
||||
break;
|
||||
}
|
||||
if($this->entity->riding != 0){
|
||||
$this->entity->setRiding(null);
|
||||
}
|
||||
break;
|
||||
case ProtocolInfo::PLAYER_INPUT_PACKET:
|
||||
if($this->spawned === false){
|
||||
break;
|
||||
}
|
||||
$this->isJumping = $packet->isJumping;
|
||||
$this->isSneaking = $packet->isSneaking;
|
||||
$this->entity->moveForward = $packet->moveForward;
|
||||
|
|
|
|||
|
|
@ -22,6 +22,62 @@ class NBT{
|
|||
$this->binary .= $bin;
|
||||
}
|
||||
|
||||
/**
|
||||
* A function to safely load sign nbt
|
||||
* @param string $str raw nbt data
|
||||
* @return false|array array with sign data, false if failed
|
||||
*/
|
||||
public function loadSignNBT($str){
|
||||
$this->offset = 0;
|
||||
$this->binary = (string) $str;
|
||||
//sign nbt in vanilla is
|
||||
/*
|
||||
* [
|
||||
* "id": "Sign",
|
||||
* "x": <int>,
|
||||
* "y": <int>,
|
||||
* "z": <int>,
|
||||
* "Text1": <string>, //max 15 chars
|
||||
* "Text2": <string>, //^
|
||||
* "Text3": <string>, //^
|
||||
* "Text4": <string> //^
|
||||
* ]
|
||||
*/
|
||||
$tag = ord($this->read(1));
|
||||
if($tag == self::TAG_COMPOUND){
|
||||
$name = $this->readTAG_STRING_maxlen(2);
|
||||
if($name != "") return false;
|
||||
$value = [];
|
||||
for($n = 0; $n < 8; ++$n){
|
||||
$tag = ord($this->read(1));
|
||||
if($tag == self::TAG_END){
|
||||
break;
|
||||
}else if($tag == self::TAG_INT){
|
||||
$name = $this->readTAG_STRING_maxlen(1);
|
||||
if($name != "x" && $name != "y" && $name != "z") return false;
|
||||
$value[$name] = $this->readTAG_INT();
|
||||
}else if($tag == self::TAG_STRING){
|
||||
$name = $this->readTAG_STRING_maxlen(5);
|
||||
if($name == "id"){
|
||||
$s = $this->readTAG_STRING_maxlen(4);
|
||||
if($s != "Sign") return false;
|
||||
$value[$name] = $s;
|
||||
}else if($name == "Text1" || $name == "Text2" || $name == "Text3" || $name == "Text4"){
|
||||
$value[$name] = $this->readTAG_STRING_maxlen(15*4); //mcpe 0.8.1 supports unicode, so the max char size 4 bytes
|
||||
}else{
|
||||
return false;
|
||||
}
|
||||
}else{
|
||||
return false;
|
||||
}
|
||||
}
|
||||
if(count($value) != 8) return false;
|
||||
return $value;
|
||||
}else{
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
public function load($str){
|
||||
$this->offset = 0;
|
||||
$this->binary = (string) $str;
|
||||
|
|
@ -66,7 +122,7 @@ class NBT{
|
|||
break;
|
||||
default:
|
||||
echo bin2hex(substr($this->binary, $this->offset - 1)) . PHP_EOL . PHP_EOL;
|
||||
die("Invalid NBT Tag $tag");
|
||||
throw new NBTException("Invalid NBT Tag $tag");
|
||||
}
|
||||
$node[$name] = $value;
|
||||
}
|
||||
|
|
@ -83,7 +139,14 @@ class NBT{
|
|||
private function feof(){
|
||||
return !isset($this->binary[$this->offset]);
|
||||
}
|
||||
|
||||
|
||||
//i guess i could have modified old method?
|
||||
//*but it will make it slower </3*
|
||||
//*the nbt needs to be completely rewritten anyway this is barely usable </3*
|
||||
public function readTAG_STRING_maxlen($ml){
|
||||
$len = Utils::readLShort($this->read(2), false);
|
||||
return $this->read($len <= $ml ? $len : $ml);
|
||||
}
|
||||
public function readTAG_STRING(){
|
||||
return $this->read(Utils::readLShort($this->read(2), false));
|
||||
}
|
||||
|
|
|
|||
8
src/utils/NBTException.php
Normal file
8
src/utils/NBTException.php
Normal file
|
|
@ -0,0 +1,8 @@
|
|||
<?php
|
||||
class NBTException extends Exception
|
||||
{
|
||||
public function __construct($message){
|
||||
parent::__construct($message);
|
||||
}
|
||||
}
|
||||
|
||||
Loading…
Add table
Add a link
Reference in a new issue