From ba4ccafa32d415421ca8612e9079c9c2b5203a80 Mon Sep 17 00:00:00 2001 From: GameHerobrine Date: Thu, 17 Jul 2025 05:27:15 +0300 Subject: [PATCH] PlayerAPI::remove removes a player from the table by his clientID, packets wont be handled after the player was kicked due to player already ingame --- src/API/PlayerAPI.php | 6 +++++- src/Player.php | 4 ++-- src/PocketMinecraftServer.php | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/API/PlayerAPI.php b/src/API/PlayerAPI.php index d043412f..4ea9b42a 100644 --- a/src/API/PlayerAPI.php +++ b/src/API/PlayerAPI.php @@ -521,7 +521,11 @@ class PlayerAPI{ if($player->username != "" and ($player->data instanceof Config)){ $this->saveOffline($player->data); } - $this->server->query("DELETE FROM players WHERE name = '" . $player->username . "';"); + + $this->server->preparedSQL->player->deleteCID->reset(); + $this->server->preparedSQL->player->deleteCID->bindValue(":CID", $CID); + $this->server->preparedSQL->player->getEq->execute(); + $this->server->api->entity->remove($player->eid); unset($player->level->players[$player->CID]); if($player->entity instanceof Entity){ diff --git a/src/Player.php b/src/Player.php index 44a61f57..2dacbb63 100755 --- a/src/Player.php +++ b/src/Player.php @@ -2115,8 +2115,8 @@ class Player{ } $u = $this->server->api->player->get($this->iusername, false); if($u !== false){ - $u = $this->server->clients[$this->CID]; - $u->close("this player already in game"); + $this->close("this player already in game"); + return; } $this->server->api->player->add($this->CID); diff --git a/src/PocketMinecraftServer.php b/src/PocketMinecraftServer.php index a9ef9924..0473610d 100644 --- a/src/PocketMinecraftServer.php +++ b/src/PocketMinecraftServer.php @@ -176,6 +176,7 @@ class PocketMinecraftServer{ $this->preparedSQL->entity->setPosition = $this->database->prepare("UPDATE entities SET x = :x, y = :y, z = :z, pitch = :pitch, yaw = :yaw WHERE EID = :eid ;"); $this->preparedSQL->entity->setLevel = $this->database->prepare("UPDATE entities SET level = :level WHERE EID = :eid ;"); + $this->preparedSQL->player->deleteCID = $this->database->prepare("DELETE FROM players WHERE CID = :cid;"); $this->preparedSQL->player->getEq = $this->database->prepare("SELECT ip,port,name FROM players WHERE name = :name;"); //'$name' $this->preparedSQL->player->getLike = $this->database->prepare("SELECT ip,port,name FROM players WHERE name LIKE :name;"); //'$name'