From c95a8d5cffc584831928b7fac394553f540b9598 Mon Sep 17 00:00:00 2001 From: GameHerobrine Date: Sun, 13 Jul 2025 20:06:00 +0300 Subject: [PATCH] using prepared statements for PlayerAPI::get --- src/API/PlayerAPI.php | 9 +++++++-- src/PocketMinecraftServer.php | 6 ++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/API/PlayerAPI.php b/src/API/PlayerAPI.php index 4bbd53dc..d043412f 100644 --- a/src/API/PlayerAPI.php +++ b/src/API/PlayerAPI.php @@ -294,7 +294,10 @@ class PlayerAPI{ if($name === ""){ return false; } - $query = $this->server->query("SELECT ip,port,name FROM players WHERE name = '$name';"); //try getting player by name first + $this->server->preparedSQL->player->getEq->reset(); + $this->server->preparedSQL->player->getEq->bindValue(":name", $name); + $query = $this->server->preparedSQL->player->getEq->execute(); + $players = []; if($query !== false and $query !== true){ while(($d = $query->fetchArray(SQLITE3_ASSOC)) !== false){ @@ -308,7 +311,9 @@ class PlayerAPI{ } } if($alike === true){ - $query = $this->server->query("SELECT ip,port,name FROM players WHERE name LIKE '$name%';"); //try getting player with non-full name match if none was found + $this->server->preparedSQL->player->getLike->reset(); + $query = $this->server->preparedSQL->player->getLike->bindValue(":name", "$name%"); + $query = $this->server->preparedSQL->player->getLike->execute(); //try getting player with non-full name match if none was found if($query !== false and $query !== true){ while(($d = $query->fetchArray(SQLITE3_ASSOC)) !== false){ $CID = PocketMinecraftServer::clientID($d["ip"], $d["port"]); diff --git a/src/PocketMinecraftServer.php b/src/PocketMinecraftServer.php index 659b32f1..a9ef9924 100644 --- a/src/PocketMinecraftServer.php +++ b/src/PocketMinecraftServer.php @@ -157,6 +157,8 @@ class PocketMinecraftServer{ public function startDatabase(){ $this->preparedSQL = new stdClass(); $this->preparedSQL->entity = new stdClass(); + $this->preparedSQL->player = new stdClass(); + $this->database = new SQLite3(":memory:"); $this->query("PRAGMA journal_mode = OFF;"); $this->query("PRAGMA encoding = \"UTF-8\";"); @@ -173,6 +175,10 @@ class PocketMinecraftServer{ $this->preparedSQL->updateAction = $this->database->prepare("UPDATE actions SET last = :time WHERE ID = :id;"); $this->preparedSQL->entity->setPosition = $this->database->prepare("UPDATE entities SET x = :x, y = :y, z = :z, pitch = :pitch, yaw = :yaw WHERE EID = :eid ;"); $this->preparedSQL->entity->setLevel = $this->database->prepare("UPDATE entities SET level = :level WHERE EID = :eid ;"); + + $this->preparedSQL->player->getEq = $this->database->prepare("SELECT ip,port,name FROM players WHERE name = :name;"); //'$name' + $this->preparedSQL->player->getLike = $this->database->prepare("SELECT ip,port,name FROM players WHERE name LIKE :name;"); //'$name' + } public function query($sql, $fetch = false){