fixed warnings when using ban/banip commands

This commit is contained in:
GameHerobrine 2025-03-16 16:36:38 +03:00
parent 3580b884d8
commit d63cbc1722

View file

@ -153,10 +153,7 @@ class BanAPI{
$output .= "Command ran as " . $player->username . ".\n"; $output .= "Command ran as " . $player->username . ".\n";
break; break;
case "op": case "op":
if(!isset($params[0])){ if(!isset($params[0])) return "Usage: /op <player>\n";
$output .= "Usage: /op <player>\n";
break;
}
$user = strtolower($params[0]); $user = strtolower($params[0]);
$player = $this->server->api->player->get($user); $player = $this->server->api->player->get($user);
if(!($player instanceof Player)){ if(!($player instanceof Player)){
@ -171,10 +168,8 @@ class BanAPI{
$this->server->api->chat->sendTo(false, "You are now op.", $player->iusername); $this->server->api->chat->sendTo(false, "You are now op.", $player->iusername);
break; break;
case "deop": case "deop":
if(!isset($params[0])){ if(!isset($params[0])) return "Usage: /deop <player>\n";
$output .= "Usage: /deop <player>\n";
break;
}
$user = strtolower($params[0]); $user = strtolower($params[0]);
$player = $this->server->api->player->get($user); $player = $this->server->api->player->get($user);
if(!($player instanceof Player)){ if(!($player instanceof Player)){
@ -254,13 +249,14 @@ class BanAPI{
switch($p){ switch($p){
case "pardon": case "pardon":
case "remove": case "remove":
if(!isset($params[0])) return "Ussage: /banip remove <ip>";
$ip = strtolower($params[0]); $ip = strtolower($params[0]);
$this->bannedIPs->remove($ip); $this->bannedIPs->remove($ip);
$this->bannedIPs->save(); $this->bannedIPs->save();
$output .= "IP \"$ip\" removed from ban list\n"; return "IP \"$ip\" removed from ban list\n";
break;
case "add": case "add":
case "ban": case "ban":
if(!isset($params[0])) return "Ussage: /banip add <username>";
$ip = strtolower($params[0]); $ip = strtolower($params[0]);
$player = $this->server->api->player->get($ip); $player = $this->server->api->player->get($ip);
if($player instanceof Player){ if($player instanceof Player){
@ -269,17 +265,14 @@ class BanAPI{
} }
$this->bannedIPs->set($ip); $this->bannedIPs->set($ip);
$this->bannedIPs->save(); $this->bannedIPs->save();
$output .= "IP \"$ip\" added to ban list\n"; return "IP \"$ip\" added to ban list\n";
break;
case "reload": case "reload":
$this->bannedIPs = new Config(DATA_PATH . "banned-ips.txt", CONFIG_LIST); $this->bannedIPs = new Config(DATA_PATH . "banned-ips.txt", CONFIG_LIST);
break; return "Reloaded banned ips list";
case "list": case "list":
$output .= "IP ban list: " . implode(", ", $this->bannedIPs->getAll(true)) . "\n"; return "IP ban list: " . implode(", ", $this->bannedIPs->getAll(true)) . "\n";
break;
default: default:
$output .= "Usage: /banip <add|remove|list|reload> [IP|player]\n"; return "Usage: /banip <add|remove|list|reload> [IP|player]\n";
break;
} }
break; break;
case "ban": case "ban":
@ -287,13 +280,14 @@ class BanAPI{
switch($p){ switch($p){
case "pardon": case "pardon":
case "remove": case "remove":
if(!isset($params[0])) return "Ussage: /ban remove <username>";
$user = strtolower($params[0]); $user = strtolower($params[0]);
$this->banned->remove($user); $this->banned->remove($user);
$this->banned->save(); $this->banned->save();
$output .= "Player \"$user\" removed from ban list\n"; return "Player \"$user\" removed from ban list\n";
break;
case "add": case "add":
case "ban": case "ban":
if(!isset($params[0])) return "Ussage: /ban add <username>";
$user = strtolower($params[0]); $user = strtolower($params[0]);
$this->banned->set($user); $this->banned->set($user);
$this->banned->save(); $this->banned->save();
@ -307,17 +301,14 @@ class BanAPI{
$this->server->api->chat->broadcast($user . " has been banned\n"); $this->server->api->chat->broadcast($user . " has been banned\n");
} }
$this->kick($user, "Banned"); $this->kick($user, "Banned");
$output .= "Player \"$user\" added to ban list\n"; return "Player \"$user\" added to ban list\n";
break;
case "reload": case "reload":
$this->banned = new Config(DATA_PATH . "banned.txt", CONFIG_LIST); $this->banned = new Config(DATA_PATH . "banned.txt", CONFIG_LIST);
break; return "Reloaded banned players list";
case "list": case "list":
$output .= "Ban list: " . implode(", ", $this->banned->getAll(true)) . "\n"; return "Ban list: " . implode(", ", $this->banned->getAll(true)) . "\n";
break;
default: default:
$output .= "Usage: /ban <add|remove|list|reload> [username]\n"; return "Usage: /ban <add|remove|list|reload> [username]\n";
break;
} }
break; break;
} }