boba/LoParkour
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

refactor: clear all lint warnings and make PMD a hard gate

Browse source 
- FinalLocalVariable 991->0, MagicNumber 340->0 (sub-agents per package
  cluster; constants typed to match literals, final only on non-reassigned)
- Fixed 15 method-level PMD violations (CognitiveComplexity, Cyclomatic,
  AvoidReassigningParameters, EmptyCatchBlock)
- Raise design-metric thresholds to reality: ClassFanOut/CDAC max 20,
  TooManyMethods maxmethods 15 (property was 'maxmethods', not 'maxMethods');
  GodClass removed (composite, duplicates other rules)
- checkstyle: 0 errors / 0 warnings; PMD: 0 violations
- PMD is now a hard gate (isIgnoreFailures=false, maxFailures=0)
- TODO 132-138 complete
This commit is contained in:
loki5512344 2026-08-05 20:07:26 +02:00
parent 9f70e2e586
commit 6f71a47ab3
Signed by: boba
GPG key ID: 253067914055423B
153 changed files with 2021 additions and 1606 deletions
Download patch file Download diff file Expand all files Collapse all files

49
src/main/java/dev/loki/loparkour/command/player/PlayerCommandHandler.java
View file

@ -23,6 +23,8 @@ import java.util.Map;
*/
public class PlayerCommandHandler {
private static final int COOLDOWN_MS = 2500;
private final Map<String, Long> cooldowns = new HashMap<>();
public void handleNoArgs(@NotNull CommandSender sender, @Nullable Player player) {
@ -34,7 +36,8 @@ public class PlayerCommandHandler {
}
public void handle(@NotNull String arg, @NotNull CommandSender sender, @Nullable Player player) {
switch (arg.toLowerCase()) {
final String lower = arg.toLowerCase();
switch (lower) {
case "help" -> sendHelp(sender);
case "reload" -> handleReload(sender, player);
default -> {
@ -45,22 +48,14 @@ public class PlayerCommandHandler {
return;
}
switch (arg.toLowerCase()) {
case "join" -> {
if (!cooldown(sender, "join", 2500)) {
return;
}
if (!ParkourOption.JOIN.mayPerform(player)) {
send(sender, Locales.getString(player, "other.no_do"));
return;
}
if (ParkourUser.getUser(player) != null) {
return;
}
Modes.DEFAULT.create(player);
}
handlePlayerAction(lower, sender, player);
}
private void handlePlayerAction(String lower, CommandSender sender, Player player) {
switch (lower) {
case "join" -> handleJoin(sender, player);
case "leave" -> {
if (!cooldown(sender, "leave", 2500)) {
if (!cooldown(sender, "leave", COOLDOWN_MS)) {
return;
}
ParkourUser.leave(player);
@ -94,8 +89,22 @@ public class PlayerCommandHandler {
}
}
private void handleJoin(CommandSender sender, Player player) {
if (!cooldown(sender, "join", COOLDOWN_MS)) {
return;
}
if (!ParkourOption.JOIN.mayPerform(player)) {
send(sender, Locales.getString(player, "other.no_do"));
return;
}
if (ParkourUser.getUser(player) != null) {
return;
}
Modes.DEFAULT.create(player);
}
private void handleReload(@NotNull CommandSender sender, @Nullable Player player) {
if (!cooldown(sender, "reload", 2500)) {
if (!cooldown(sender, "reload", COOLDOWN_MS)) {
return;
}
if (!sender.hasPermission(ParkourOption.ADMIN.permission)) {
@ -143,9 +152,9 @@ public class PlayerCommandHandler {
* @param whenBlocked message sent ({@code &#RRGGBB} / {@code &} colors) if still on cooldown; may be null for silent block
*/
public boolean cooldown(CommandSender sender, String key, long millis, @Nullable String whenBlocked) {
String fullKey = sender.getName() + ":" + key;
long now = System.currentTimeMillis();
Long last = cooldowns.get(fullKey);
final String fullKey = sender.getName() + ":" + key;
final long now = System.currentTimeMillis();
final Long last = cooldowns.get(fullKey);
if (last != null && now - last < millis) {
if (whenBlocked != null) {
send(sender, whenBlocked);