boba/LoParkour
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

refactor: clear all lint warnings and make PMD a hard gate

Browse source 
- FinalLocalVariable 991->0, MagicNumber 340->0 (sub-agents per package
  cluster; constants typed to match literals, final only on non-reassigned)
- Fixed 15 method-level PMD violations (CognitiveComplexity, Cyclomatic,
  AvoidReassigningParameters, EmptyCatchBlock)
- Raise design-metric thresholds to reality: ClassFanOut/CDAC max 20,
  TooManyMethods maxmethods 15 (property was 'maxmethods', not 'maxMethods');
  GodClass removed (composite, duplicates other rules)
- checkstyle: 0 errors / 0 warnings; PMD: 0 violations
- PMD is now a hard gate (isIgnoreFailures=false, maxFailures=0)
- TODO 132-138 complete
This commit is contained in:
loki5512344 2026-08-05 20:07:26 +02:00
parent 9f70e2e586
commit 6f71a47ab3
Signed by: boba
GPG key ID: 253067914055423B
153 changed files with 2021 additions and 1606 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/main/java/dev/loki/loparkour/menu/settings/SettingsMenu.java
View file

@ -12,16 +12,21 @@ import org.jetbrains.annotations.NotNull;
public class SettingsMenu extends LPMenu {
private static final int ROWS = 3;
private static final int SLOT_PARKOUR_SETTINGS = 11;
private static final int SLOT_LANG = 13;
private static final int SLOT_CLOSE = 22;
@Override
public void open(@NotNull Player player) {
String locale = locale(player);
String title = Locales.getString(locale, "settings.name");
final String locale = locale(player);
final String title = Locales.getString(locale, "settings.name");
InventoryGUI gui = baseGui(title, 3);
InventoryGUI gui = baseGui(title, ROWS);
if (ParkourOption.PARKOUR_SETTINGS.mayPerform(player) && ParkourPlayer.isPlayer(player)) {
gui = gui.setItem(11, localeItem(player, "settings.parkour_settings.item"), e -> {
ParkourPlayer pp = ParkourPlayer.getPlayer(player);
gui = gui.setItem(SLOT_PARKOUR_SETTINGS, localeItem(player, "settings.parkour_settings.item"), e -> {
final ParkourPlayer pp = ParkourPlayer.getPlayer(player);
if (pp != null) {
pp.session.generator.menu(pp);
}
@ -29,16 +34,16 @@ public class SettingsMenu extends LPMenu {
}
if (ParkourOption.LANG.mayPerform(player) && ParkourUser.isUser(player)) {
String langName = Locales.getString(locale, "name");
gui = gui.setItem(13, localeItem(locale, "settings.lang.item", langName), e -> {
ParkourPlayer pp = ParkourPlayer.getPlayer(player);
final String langName = Locales.getString(locale, "name");
gui = gui.setItem(SLOT_LANG, localeItem(locale, "settings.lang.item", langName), e -> {
final ParkourPlayer pp = ParkourPlayer.getPlayer(player);
if (pp != null) {
Menus.LANG.open(pp);
}
});
}
gui.setItem(22, closeButton(player), e -> player.closeInventory())
gui.setItem(SLOT_CLOSE, closeButton(player), e -> player.closeInventory())
.open(player);
}
}