From bfeecb0866dfac6ed8893305c2785a25030222ec Mon Sep 17 00:00:00 2001 From: loki5512344 Date: Sun, 12 Jul 2026 11:52:54 +0200 Subject: [PATCH] fix: resolve 266/375 checkstyle violations, add lolib jar --- build.gradle.kts | 2 +- .../java/dev/loki/loparkour/LoParkour.java | 4 +- .../adaptive/model/AdaptiveConfig.java | 30 +++--- .../dev/loki/loparkour/api/core/Registry.java | 19 ++-- .../loparkour/bootstrap/PluginBootstrap.java | 1 - .../loparkour/command/LoParkourCommand.java | 57 +++++++--- .../command/admin/AdminCommandHandler.java | 82 ++++++++++---- .../command/player/PlayerCommandHandler.java | 32 ++++-- .../schematic/SchematicCommandHandler.java | 13 ++- .../loki/loparkour/config/core/Config.java | 4 +- .../loparkour/config/core/ConfigLoader.java | 3 + .../loparkour/config/core/ConfigUpdater.java | 52 +++++++-- .../loparkour/config/locale/LocaleCache.java | 13 ++- .../loparkour/config/locale/LocaleLoader.java | 10 +- .../loki/loparkour/config/locale/Locales.java | 27 +++-- .../loki/loparkour/config/options/Option.java | 32 ++++-- .../config/options/OptionGeneral.java | 10 +- .../config/options/OptionGeneration.java | 22 +++- .../config/options/OptionParticles.java | 1 - .../core/coordinator/ParkourGenerator.java | 4 +- .../generator/core/model/GeneratorState.java | 5 +- .../generator/core/model/Profile.java | 10 +- .../generator/effect/EffectManager.java | 13 ++- .../jump/calculation/JumpCalculator.java | 4 +- .../generator/jump/placement/BlockPlacer.java | 12 ++- .../jump/placement/BlockSelector.java | 4 +- .../lifecycle/player/GeneratorCleanup.java | 17 ++- .../player/PlayerInteractionHandler.java | 4 +- .../loparkour/ghost/core/GhostManager.java | 40 +++++-- .../loparkour/ghost/core/GhostPlayer.java | 22 +++- .../loparkour/ghost/core/GhostRecorder.java | 8 +- .../loki/loparkour/ghost/model/GhostData.java | 9 +- .../leaderboard/core/Leaderboard.java | 7 +- .../leaderboard/core/LeaderboardSorter.java | 18 +++- .../persistence/LeaderboardStorage.java | 1 - .../gameplay/ParkourRestrictionListener.java | 102 +++++++++++++----- .../player/PlayerConnectionListener.java | 8 +- .../menu/community/SingleLeaderboardMenu.java | 5 +- .../dev/loki/loparkour/menu/core/LPMenu.java | 7 +- .../dev/loki/loparkour/menu/core/Menus.java | 5 +- .../menu/lobby/PlayerManagementMenu.java | 5 +- .../loparkour/menu/play/SpectatorMenu.java | 5 +- .../loparkour/menu/settings/LangMenu.java | 2 +- .../menu/settings/ParkourSettingsMenu.java | 5 +- .../dev/loki/loparkour/mode/base/Modes.java | 13 ++- .../loki/loparkour/mode/impl/CoopMode.java | 6 +- .../loki/loparkour/mode/impl/DefaultMode.java | 1 - .../loparkour/mode/impl/GravityShiftMode.java | 9 +- .../mode/impl/InvisibleBarrierMode.java | 75 ++++++++----- .../loki/loparkour/mode/impl/RaceMode.java | 2 +- .../loparkour/mode/impl/SpectatorMode.java | 1 - .../loparkour/mode/impl/SpeedrunMode.java | 18 +++- .../loparkour/player/core/ParkourPlayer.java | 11 +- .../loparkour/player/core/ParkourUser.java | 15 ++- .../loparkour/player/data/InventoryData.java | 17 ++- .../loparkour/player/data/PreviousData.java | 4 +- .../loparkour/player/service/BungeeUtil.java | 5 +- .../player/service/PlayerSettingsManager.java | 8 +- .../player/service/ScoreboardManager.java | 12 ++- .../player/service/UserRegistry.java | 6 +- .../player/spectator/ParkourSpectator.java | 6 +- .../loki/loparkour/reward/core/Reward.java | 4 +- .../loki/loparkour/reward/core/Rewards.java | 11 +- .../schematic/registry/Schematics.java | 3 + .../dev/loki/loparkour/storage/Storage.java | 3 + .../loparkour/storage/disk/StorageDisk.java | 18 +++- .../loparkour/storage/sql/SQLDataMapper.java | 5 +- .../storage/sql/SQLQueryBuilder.java | 5 +- .../storage/sql/SQLQueryExecutor.java | 8 +- .../loparkour/storage/sql/StorageSQL.java | 23 ++-- .../dev/loki/loparkour/util/item/Item.java | 1 + .../dev/loki/loparkour/util/misc/Probs.java | 3 + .../loki/loparkour/util/misc/SkullSetter.java | 5 +- .../loparkour/util/particle/ParticleData.java | 2 - .../loparkour/util/particle/ParticleUtil.java | 7 +- .../loki/loparkour/util/text/ColorUtil.java | 3 + .../loki/loparkour/util/world/Locations.java | 3 + .../loki/loparkour/world/core/Divider.java | 3 + .../dev/loki/loparkour/world/core/World.java | 13 ++- 79 files changed, 773 insertions(+), 292 deletions(-) diff --git a/build.gradle.kts b/build.gradle.kts index 0c74ceb..309cf6e 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -174,7 +174,7 @@ checkstyle { configFile = file("config/checkstyle/checkstyle.xml") isIgnoreFailures = true maxErrors = 0 - maxWarnings = 400 + maxWarnings = 200 } tasks.withType().configureEach { diff --git a/src/main/java/dev/loki/loparkour/LoParkour.java b/src/main/java/dev/loki/loparkour/LoParkour.java index 71d161b..289e398 100644 --- a/src/main/java/dev/loki/loparkour/LoParkour.java +++ b/src/main/java/dev/loki/loparkour/LoParkour.java @@ -29,7 +29,7 @@ public final class LoParkour extends LoPlugin { public static final String NAME = "&#FF6464&lLoParkour&r"; public static final String PREFIX = NAME + " 񢩈» &#A0A0A0"; - private static final Gson gson = new GsonBuilder() + private static final Gson GSON = new GsonBuilder() .setPrettyPrinting() .excludeFieldsWithoutExposeAnnotation() .create(); @@ -41,7 +41,7 @@ public final class LoParkour extends LoPlugin { private static PAPIHook placeholderHook; public static Gson getGson() { - return gson; + return GSON; } public static void log(String message) { diff --git a/src/main/java/dev/loki/loparkour/adaptive/model/AdaptiveConfig.java b/src/main/java/dev/loki/loparkour/adaptive/model/AdaptiveConfig.java index faac218..115aa45 100644 --- a/src/main/java/dev/loki/loparkour/adaptive/model/AdaptiveConfig.java +++ b/src/main/java/dev/loki/loparkour/adaptive/model/AdaptiveConfig.java @@ -11,7 +11,7 @@ import java.util.concurrent.ConcurrentHashMap; */ public class AdaptiveConfig { - private static final ConcurrentHashMap cache = new ConcurrentHashMap<>(); + private static final ConcurrentHashMap CACHE = new ConcurrentHashMap<>(); private static volatile boolean initialized = false; // Configuration keys @@ -39,12 +39,12 @@ public class AdaptiveConfig { return; } - cache.put(KEY_ENABLED, Config.CONFIG.getBoolean(KEY_ENABLED, DEFAULT_ENABLED)); - cache.put(KEY_MIN_SESSIONS, Config.CONFIG.getInt(KEY_MIN_SESSIONS, DEFAULT_MIN_SESSIONS)); - cache.put(KEY_UPDATE_INTERVAL, Config.CONFIG.getInt(KEY_UPDATE_INTERVAL, DEFAULT_UPDATE_INTERVAL)); - cache.put(KEY_RATING_WEIGHT, configDouble(KEY_RATING_WEIGHT, DEFAULT_RATING_WEIGHT)); - cache.put(KEY_CONFIDENCE_THRESHOLD, configDouble(KEY_CONFIDENCE_THRESHOLD, DEFAULT_CONFIDENCE_THRESHOLD)); - cache.put(KEY_NEAR_MISS_DISTANCE, configDouble(KEY_NEAR_MISS_DISTANCE, DEFAULT_NEAR_MISS_DISTANCE)); + CACHE.put(KEY_ENABLED, Config.CONFIG.getBoolean(KEY_ENABLED, DEFAULT_ENABLED)); + CACHE.put(KEY_MIN_SESSIONS, Config.CONFIG.getInt(KEY_MIN_SESSIONS, DEFAULT_MIN_SESSIONS)); + CACHE.put(KEY_UPDATE_INTERVAL, Config.CONFIG.getInt(KEY_UPDATE_INTERVAL, DEFAULT_UPDATE_INTERVAL)); + CACHE.put(KEY_RATING_WEIGHT, configDouble(KEY_RATING_WEIGHT, DEFAULT_RATING_WEIGHT)); + CACHE.put(KEY_CONFIDENCE_THRESHOLD, configDouble(KEY_CONFIDENCE_THRESHOLD, DEFAULT_CONFIDENCE_THRESHOLD)); + CACHE.put(KEY_NEAR_MISS_DISTANCE, configDouble(KEY_NEAR_MISS_DISTANCE, DEFAULT_NEAR_MISS_DISTANCE)); initialized = true; } @@ -55,7 +55,7 @@ public class AdaptiveConfig { */ public static void reload() { initialized = false; - cache.clear(); + CACHE.clear(); init(); } @@ -66,7 +66,7 @@ public class AdaptiveConfig { */ public static boolean isEnabled() { ensureInitialized(); - return (boolean) cache.getOrDefault(KEY_ENABLED, DEFAULT_ENABLED); + return (boolean) CACHE.getOrDefault(KEY_ENABLED, DEFAULT_ENABLED); } /** @@ -76,7 +76,7 @@ public class AdaptiveConfig { */ public static int getMinSessions() { ensureInitialized(); - return (int) cache.getOrDefault(KEY_MIN_SESSIONS, DEFAULT_MIN_SESSIONS); + return (int) CACHE.getOrDefault(KEY_MIN_SESSIONS, DEFAULT_MIN_SESSIONS); } /** @@ -86,7 +86,7 @@ public class AdaptiveConfig { */ public static int getUpdateInterval() { ensureInitialized(); - return (int) cache.getOrDefault(KEY_UPDATE_INTERVAL, DEFAULT_UPDATE_INTERVAL); + return (int) CACHE.getOrDefault(KEY_UPDATE_INTERVAL, DEFAULT_UPDATE_INTERVAL); } /** @@ -96,7 +96,7 @@ public class AdaptiveConfig { */ public static double getRatingWeight() { ensureInitialized(); - Object value = cache.get(KEY_RATING_WEIGHT); + Object value = CACHE.get(KEY_RATING_WEIGHT); if (value instanceof Double) { return (double) value; } @@ -110,7 +110,7 @@ public class AdaptiveConfig { */ public static double getConfidenceThreshold() { ensureInitialized(); - Object value = cache.get(KEY_CONFIDENCE_THRESHOLD); + Object value = CACHE.get(KEY_CONFIDENCE_THRESHOLD); if (value instanceof Double) { return (double) value; } @@ -124,7 +124,7 @@ public class AdaptiveConfig { */ public static double getNearMissDistance() { ensureInitialized(); - Object value = cache.get(KEY_NEAR_MISS_DISTANCE); + Object value = CACHE.get(KEY_NEAR_MISS_DISTANCE); if (value instanceof Double) { return (double) value; } @@ -152,7 +152,7 @@ public class AdaptiveConfig { public static T get(@NotNull String key, @NotNull T defaultValue) { ensureInitialized(); @SuppressWarnings("unchecked") - T value = (T) cache.get(key); + T value = (T) CACHE.get(key); return value != null ? value : defaultValue; } } diff --git a/src/main/java/dev/loki/loparkour/api/core/Registry.java b/src/main/java/dev/loki/loparkour/api/core/Registry.java index f76cafc..d416506 100644 --- a/src/main/java/dev/loki/loparkour/api/core/Registry.java +++ b/src/main/java/dev/loki/loparkour/api/core/Registry.java @@ -16,8 +16,11 @@ import java.util.List; */ public final class Registry { - private static final LinkedList modes = new LinkedList<>(); - private static final LinkedList