boba/LoParkour
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix critical gameplay bugs in rewrite-v2

Browse source 
1. Fixed locale loading - changed from async to sync
   - Locales now load synchronously on startup
   - Prevents GUI showing stone items before locales load

2. Fixed infinite falling bug
   - Added player teleport to spawn in processFall()
   - Players now respawn correctly after falling

3. Fixed parkour generation not working
   - Added missing tick cycle in SessionStateManager
   - Generator now ticks every server tick (50ms)
   - Parkour blocks now generate continuously

All three major bugs fixed and tested.
This commit is contained in:
loki 2026-04-09 12:07:07 +02:00
parent e5dd567ca9
commit c142d21a26
3 changed files with 58 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

41
src/main/java/dev/loki/loparkour/session/SessionStateManager.java
View file

@ -1,8 +1,11 @@
package dev.loki.loparkour.session;
import dev.loki.loparkour.LoParkour;
import dev.loki.loparkour.generator.ParkourGenerator;
import dev.loki.loparkour.player.ParkourUser;
import dev.loki.loparkour.world.Divider;
import dev.lolib.scheduler.Scheduler;
import dev.lolib.scheduler.ScheduledTask;
import org.bukkit.Location;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
@ -20,6 +23,7 @@ public class SessionStateManager {
private Location spawnLocation;
private Session.Visibility visibility = Session.Visibility.PUBLIC;
private final Map<ParkourUser, Boolean> mutedUsers = new HashMap<>();
private ScheduledTask tickTask = null;
public SessionStateManager(@NotNull Session session) {
this.session = session;
@ -31,26 +35,57 @@ public class SessionStateManager {
public void initialize(@NotNull Function<Session, ParkourGenerator> generatorFunction) {
// Allocate spawn location
this.spawnLocation = Divider.add(session);
// Create generator
ParkourGenerator generator = generatorFunction.apply(session);
session.setGenerator(generator);
// Build island at spawn location
generator.island.build(spawnLocation);
// Start tick cycle for generator
startTickCycle();
}
/**
* Clean up session resources.
*/
public void cleanup() {
// Stop tick cycle
stopTickCycle();
if (session.generator != null) {
session.generator.reset(false);
}
Divider.remove(session);
mutedUsers.clear();
}
/**
* Start tick cycle for generator.
*/
private void startTickCycle() {
if (session.generator == null || tickTask != null) {
return;
}
tickTask = Scheduler.get(LoParkour.getPlugin()).runTimer(() -> {
if (session.generator != null) {
session.generator.tick();
}
}, 0, 1); // Run every tick (1 = 50ms)
}
/**
* Stop tick cycle.
*/
private void stopTickCycle() {
if (tickTask != null) {
tickTask.cancel();
tickTask = null;
}
}
/**
* Set session visibility.