boba/LoParkour
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix critical bugs and Caffeine ClassNotFoundException

Browse source 
- Disabled minimize in shadowJar (was removing Caffeine's dynamic classes)
- Fixed Score.fromString() ArrayIndexOutOfBoundsException
- Fixed Leaderboard DIFFICULTY sort NumberFormatException
- Fixed PAPIHook parsing errors (difficulty, score_until, rank)
- Fixed HoloHook parsing errors (rank, difficulty)
- Added proper error handling for all Integer/Double.parseX() calls
This commit is contained in:
loki 2026-04-09 12:02:01 +02:00
parent 5526910bef
commit e5dd567ca9
5 changed files with 78 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/main/java/dev/loki/loparkour/hook/HoloHook.java
View file

@ -47,7 +47,12 @@ public class HoloHook {
String type = split[1].toLowerCase();
String rank = split[2].replace("#", "");
Score score = leaderboard.getScoreAtRank(Integer.parseInt(rank));
Score score;
try {
score = leaderboard.getScoreAtRank(Integer.parseInt(rank));
} catch (NumberFormatException e) {
return "?";
}
if (score == null) {
return "?";
@ -69,7 +74,15 @@ public class HoloHook {
return "?";
}
double difficulty = Double.parseDouble(string);
try {
double difficulty = Double.parseDouble(string);
return parseDifficultyValue(difficulty);
} catch (NumberFormatException e) {
return "?";
}
}
private static String parseDifficultyValue(double difficulty) {
if (difficulty <= 0.25) {
return "easy";
} else if (difficulty <= 0.5) {

52
src/main/java/dev/loki/loparkour/hook/PAPIHook.java
View file

@ -74,7 +74,17 @@ public class PAPIHook extends PlaceholderExpansion {
return getInfiniteScore(params.replace("difficulty_rank_", ""), Score::difficulty);
} else if (params.contains("difficulty_string_rank_")) {
return getInfiniteScore(params.replace("difficulty_string_rank_", ""),
score -> parseDifficulty(Double.parseDouble(score.difficulty().contains("?") ? "2" : score.difficulty())));
score -> {
String diff = score.difficulty();
if ("?".equals(diff)) {
return parseDifficulty(2.0);
}
try {
return parseDifficulty(Double.parseDouble(diff));
} catch (NumberFormatException e) {
return parseDifficulty(2.0);
}
});
}
// placeholders that require player
@ -132,10 +142,14 @@ public class PAPIHook extends PlaceholderExpansion {
default -> {
if (params.contains("score_until_")) {
String replaced = params.replace("score_until_", "");
int interval = Integer.parseInt(replaced);
if (interval > 0) {
return Integer.toString(interval - (generator.state.score % interval));
} else {
try {
int interval = Integer.parseInt(replaced);
if (interval > 0) {
return Integer.toString(interval - (generator.state.score % interval));
} else {
return "0";
}
} catch (NumberFormatException e) {
return "0";
}
}
@ -164,20 +178,24 @@ public class PAPIHook extends PlaceholderExpansion {
Leaderboard leaderboard = null;
Matcher matcher = INFINITE_REGEX.matcher(rankData);
// use mode-specific format
// x_mode_rank
if (matcher.matches()) {
String name = matcher.group(1);
rank = Integer.parseInt(matcher.group(2));
try {
// use mode-specific format
// x_mode_rank
if (matcher.matches()) {
String name = matcher.group(1);
rank = Integer.parseInt(matcher.group(2));
Mode mode = Registry.getMode(name);
if (mode != null) {
leaderboard = mode.getLeaderboard();
Mode mode = Registry.getMode(name);
if (mode != null) {
leaderboard = mode.getLeaderboard();
}
// use generic format
// x_rank
} else {
rank = Integer.parseInt(rankData);
}
// use generic format
// x_rank
} else {
rank = Integer.parseInt(rankData);
} catch (NumberFormatException e) {
return "?";
}
if (leaderboard == null) {