Fix all clippy warnings: collapsible_if, for_kv_map, vec_init_then_push, let_and_return, manual_div_ceil, useless_conversion, needless_borrows, manual_is_multiple_of, new_without_default, unnecessary_lazy_evaluations

crates/scripting/src/lib.rs

@@ -52,7 +52,7 @@ fn generate_heightmap_flat_fn(
     let flat = FlatHeightMap {
         height: height as i16,
     };
-    for (_, tile) in &mut dim.tiles {
+    for tile in dim.tiles.values_mut() {
         flat.generate(tile, world.seed);
     }
     Ok(())
@@ -77,7 +77,7 @@ fn generate_heightmap_noise_fn(
         scale_x: 1.0,
         scale_z: 1.0,
     };
-    for (_, tile) in &mut dim.tiles {
+    for tile in dim.tiles.values_mut() {
         noise.generate(tile, seed as u64);
     }
     Ok(())
@@ -117,12 +117,18 @@ fn generate_layers_fn(world: &mut World, dim_name: &str) -> Result<(), Box<EvalA
         .iter_mut()
         .find(|d| d.name == dim_name)
         .ok_or_else(|| format!("Dimension '{}' not found", dim_name))?;
-    for (_, tile) in &mut dim.tiles {
+    for tile in dim.tiles.values_mut() {
         generate_all_layers(tile, world.seed);
     }
     Ok(())
 }
 
+impl Default for ScriptEngine {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl ScriptEngine {
     pub fn new() -> Self {
         let mut engine = Engine::new();

crates/scripting/tests/integration_test.rs

@@ -32,7 +32,7 @@ fn test_generate_flat_heightmap() {
         .unwrap();
     let loaded: World = terrafier_core::io::load_binary(Path::new("/tmp/test_flat.tfw")).unwrap();
     if let Some(dim) = loaded.dimensions.first() {
-        for (_, tile) in &dim.tiles {
+        for tile in dim.tiles.values() {
             for z in 0..128 {
                 for x in 0..128 {
                     assert_eq!(tile.get_height(x, z), 64);