boba/discord-bot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

chore: revert Lavalink timeout to 30s, add PMD + stricter checkstyle

Browse source 
- LavalinkManager: httpTimeout back to 30s (stagger delays are the real fix)
- checkstyle: comprehensive ruleset from LoParkour (200-line files, complexity, naming)
- PMD: ruleset with CognitiveComplexity, CloseResource, TooManyMethods etc
- Both tools run with ignoreFailures=true (warnings only, don't block build)
This commit is contained in:
loki5512344 2026-08-06 17:53:23 +02:00
parent 10acbc5ecb
commit 74be4214aa
Signed by: boba
GPG key ID: 253067914055423B
5 changed files with 208 additions and 186 deletions
Download patch file Download diff file Expand all files Collapse all files

38
config/checkstyle/suppressions.xml Normal file
View file

@ -0,0 +1,38 @@
<?xml version="1.0"?>
<!DOCTYPE suppressions PUBLIC
"-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
"https://checkstyle.org/dtds/suppressions_1_2.dtd">
<suppressions>
<!-- IllegalCatch: defensive boundary catches in bot entry points and migration -->
<suppress checks="IllegalCatch" files=".*[\\/]bootstrap[\\/]App\.java"/>
<suppress checks="IllegalCatch" files=".*[\\/]DatabaseMigration\.java"/>
<suppress checks="IllegalCatch" files=".*[\\/]CommandExceptionHandler\.java"/>
<!-- NPathComplexity: legacy files pending refactor -->
<suppress checks="NPathComplexity" files=".*[\\/]ModerationLogger\.java"/>
<suppress checks="NPathComplexity" files=".*[\\/]VoiceChannelManager\.java"/>
<suppress checks="NPathComplexity" files=".*[\\/]PlayCommand\.java"/>
<suppress checks="NPathComplexity" files=".*[\\/]MuteCommand\.java"/>
<suppress checks="NPathComplexity" files=".*[\\/]WarnCommand\.java"/>
<suppress checks="NPathComplexity" files=".*[\\/]RankCardGenerator\.java"/>
<suppress checks="NPathComplexity" files=".*[\\/]SqlEconomyRepository\.java"/>
<suppress checks="NPathComplexity" files=".*[\\/]BlackjackService\.java"/>
<!-- FileLength: legacy files pending decomposition -->
<suppress checks="FileLength" files=".*[\\/]FeatureTables\.java"/>
<suppress checks="FileLength" files=".*[\\/]DatabaseMigration\.java"/>
<suppress checks="FileLength" files=".*[\\/]ModerationLogger\.java"/>
<suppress checks="FileLength" files=".*[\\/]VoiceChannelManager\.java"/>
<suppress checks="FileLength" files=".*[\\/]VoiceSetupPrefixCommand\.java"/>
<suppress checks="FileLength" files=".*[\\/]RadioManager\.java"/>
<suppress checks="FileLength" files=".*[\\/]MetricsCollector\.java"/>
<suppress checks="FileLength" files=".*[\\/]WarnCommand\.java"/>
<suppress checks="FileLength" files=".*[\\/]GenerateRatingsCommand\.java"/>
<suppress checks="FileLength" files=".*[\\/]BlackjackService\.java"/>
<suppress checks="FileLength" files=".*[\\/]SqlEconomyRepository\.java"/>
<suppress checks="FileLength" files=".*[\\/]GuildMusicManager\.java"/>
<suppress checks="FileLength" files=".*[\\/]QueueSlashHandler\.java"/>
<suppress checks="FileLength" files=".*[\\/]MusicBotControlHandler\.java"/>
<suppress checks="FileLength" files=".*[\\/]QueueCommands\.java"/>
</suppressions>