boba/discord-bot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: JDAVoiceUpdateListener null channel race drops voice server update

Browse source 
The local copy of JDAVoiceUpdateListener.onVoiceServerUpdate() checked
if the bot's cached voice channel was null and returned early, silently
dropping the voice server update. Discord often sends the voice server
update BEFORE the voice state update is processed by JDA, so the channel
was always null on first attempt -> Lavalink never received the update
-> voice connection never established -> timeout.

Fix: pass null channelId to Lavalink's VoiceState instead of aborting.
This matches the Kotlin original library code.
This commit is contained in:
loki5512344 2026-07-13 00:06:22 +02:00
parent fdc9df2946
commit fa5a6aab8f
Signed by: boba
GPG key ID: 253067914055423B
2 changed files with 4 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/main/java/creator/loki/feature/radio/RadioManager.java
View file

@ -97,22 +97,8 @@ public class RadioManager {
logger.warn("Radio: self member is null for guild {}", guildId);
return;
}
logger.debug(
"Radio: initial voice state for guild {}: inAudioChannel={}",
guildId,
self.getVoiceState().inAudioChannel());
for (int i = 0; i < 25; i++) {
if (self.getVoiceState().inAudioChannel()) break;
logger.debug(
"Radio: waiting for voice state in guild {} (attempt {})", guildId, i + 1);
try {
Thread.sleep(200);
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
return;
}
}
if (!self.getVoiceState().inAudioChannel()) {
if (!VoiceHelper.waitForCondition(
() -> self.getVoiceState().inAudioChannel(), VOICE_TIMEOUT_MS, TimeUnit.MILLISECONDS)) {
logger.warn(
"Radio: voice connection timeout for guild {} (channel: {})",
guildId,

4
src/main/java/dev/arbjerg/lavalink/libraries/jda/JDAVoiceUpdateListener.java
View file

@ -27,9 +27,9 @@ public class JDAVoiceUpdateListener implements VoiceDispatchInterceptor {
if (selfMember == null) return;
AudioChannel channel = selfMember.getVoiceState().getChannel();
if (channel == null) return;
String channelId = channel != null ? String.valueOf(channel.getId()) : null;
VoiceState state = new VoiceState(token, endpoint, sessionId, channel.getId());
VoiceState state = new VoiceState(token, endpoint, sessionId, channelId);
VoiceRegion region = VoiceRegion.Companion.fromEndpoint(endpoint);
lavalink.getOrCreateLink(guild.getIdLong(), region).onVoiceServerUpdate(state);
}