Security:
- An empty API_PASSWORD passed validation (only the literal "changeme" was
rejected) and verify_password("", "") returned true, so a login with an
empty password minted an admin token. Require >= 16 characters and >= 32
non-whitespace bytes for JWT_SECRET; verify rejects an empty stored secret.
- syn_challenge_enabled required a real challenge_secret_hex: the public
placeholder from config.h is now rejected in every spelling.
- docker-compose: Redis/ClickHouse/Grafana are loopback-only and every
password uses ${VAR:?} instead of a default. An exposed Redis was a way to
lift bans and publish unbans to the whole fleet with one redis-cli.
- Empty CORS_ORIGIN no longer means "allow any origin".
- ban_cidr / userspace blacklist validate and mask prefixes; CIDR bans are
stored as ranges, so a /24 or /64 ban actually covers the subnet (before,
only the network address was blocked).
Availability:
- ClickHouse client has connect/request timeouts and no mutex held across
await: a hung analytics backend can no longer freeze the ban path. Events
go through a bounded buffer with a drop counter.
- Redis uses a ConnectionManager with per-command timeouts; pubsub and
reconcile reset the backoff after success; publish cannot block shutdown.
- Ban durations from pubsub are clamped and use checked_add; the sync task
survives panics instead of silently dying.
- Blacklist TOCTOU (remove_if) and replace_redis no longer empties the table
during a Redis reconnect.
- RateLimiter and reputation have hard caps with incremental eviction instead
of an unbounded DashMap and a stop-the-world retain.
- The attack detector scores before updating its baseline and needs several
quiet windows to leave UnderAttack, so a sustained flood keeps banning new
offenders instead of ending after one tick.
- accept() backs off on EMFILE/ENFILE, shutdown Err is treated as shutdown,
a global semaphore bounds in-flight connections, rate limiting runs before
PoW, whitelisted IPs are never banned, and connect/handshake/relay have
timeouts with an idle budget.
- PoW uses the configured difficulty as a floor, the clamp is enforced, and
nonce framing survives split segments and coalesced handshake bytes.
- Subnet tracker memory is capped (prefixes and per-prefix sources) and the
monitor bans with the configured TTL.
CI and docs:
- CI runs the test suite with --no-default-features --features protocol-http;
make ebpf fails on errors; the secrets gate catches weak compose defaults.
- doctor skips protected endpoints without a token and exits non-zero on
failure; a drain timeout returns exit code 1.
- TODO §2b records the review findings, what is fixed and what is deferred;
configuration/testing docs describe the new XDP and secret semantics.
80 lines
2.3 KiB
Rust
80 lines
2.3 KiB
Rust
//! Adaptive PoW difficulty: configured floor, range clamping and the rate
|
|
//! ladder. The adjuster lives in `src/engine/challenge/difficulty.rs`; these
|
|
//! tests are the only consumer of the range constants.
|
|
|
|
use rampart::engine::challenge::{DifficultyAdjuster, MAX_DIFFICULTY, MIN_DIFFICULTY};
|
|
|
|
#[test]
|
|
fn idle_uses_the_configured_floor() {
|
|
let adjuster = DifficultyAdjuster::new(4, 10);
|
|
assert_eq!(adjuster.current_difficulty(), 4);
|
|
}
|
|
|
|
#[test]
|
|
fn configured_pow_difficulty_is_the_starting_point() {
|
|
// `[pow].difficulty = 7` must not be ignored until the first connection.
|
|
assert_eq!(DifficultyAdjuster::with_floor(7).current_difficulty(), 7);
|
|
}
|
|
|
|
#[test]
|
|
fn configured_floor_can_be_lower_than_the_old_hardcoded_minimum() {
|
|
assert_eq!(DifficultyAdjuster::with_floor(2).current_difficulty(), 2);
|
|
}
|
|
|
|
#[test]
|
|
fn configured_floor_is_clamped_to_the_supported_range() {
|
|
assert_eq!(DifficultyAdjuster::with_floor(0).current_difficulty(), MIN_DIFFICULTY);
|
|
assert_eq!(DifficultyAdjuster::with_floor(250).current_difficulty(), MAX_DIFFICULTY);
|
|
}
|
|
|
|
#[test]
|
|
fn inverted_range_is_swapped_instead_of_breaking_the_clamp() {
|
|
let mut adjuster = DifficultyAdjuster::new(9, 5);
|
|
assert_eq!(adjuster.current_difficulty(), 5, "lower end is the starting point");
|
|
for _ in 0..600 {
|
|
adjuster.record_connection();
|
|
}
|
|
assert_eq!(
|
|
adjuster.current_difficulty(),
|
|
9,
|
|
"under load the swapped upper end applies"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn pinned_range_never_moves() {
|
|
let mut adjuster = DifficultyAdjuster::new(6, 6);
|
|
for _ in 0..600 {
|
|
adjuster.record_connection();
|
|
}
|
|
assert_eq!(adjuster.current_difficulty(), 6);
|
|
}
|
|
|
|
#[test]
|
|
fn rate_ladder_is_clamped_to_the_configured_range() {
|
|
let mut adjuster = DifficultyAdjuster::new(7, 8);
|
|
for _ in 0..60 {
|
|
adjuster.record_connection();
|
|
}
|
|
// Raw ladder step is 6, below the configured floor.
|
|
assert_eq!(adjuster.current_difficulty(), 7);
|
|
for _ in 60..201 {
|
|
adjuster.record_connection();
|
|
}
|
|
// Raw ladder step is 8 and fits the range.
|
|
assert_eq!(adjuster.current_difficulty(), 8);
|
|
for _ in 201..600 {
|
|
adjuster.record_connection();
|
|
}
|
|
// Raw ladder step is MAX_DIFFICULTY, above the configured ceiling.
|
|
assert_eq!(adjuster.current_difficulty(), 8);
|
|
}
|
|
|
|
#[test]
|
|
fn default_range_rises_to_ten_under_load() {
|
|
let mut adjuster = DifficultyAdjuster::default();
|
|
for _ in 0..600 {
|
|
adjuster.record_connection();
|
|
}
|
|
assert_eq!(adjuster.current_difficulty(), 10);
|
|
}
|