Security:
- An empty API_PASSWORD passed validation (only the literal "changeme" was
rejected) and verify_password("", "") returned true, so a login with an
empty password minted an admin token. Require >= 16 characters and >= 32
non-whitespace bytes for JWT_SECRET; verify rejects an empty stored secret.
- syn_challenge_enabled required a real challenge_secret_hex: the public
placeholder from config.h is now rejected in every spelling.
- docker-compose: Redis/ClickHouse/Grafana are loopback-only and every
password uses ${VAR:?} instead of a default. An exposed Redis was a way to
lift bans and publish unbans to the whole fleet with one redis-cli.
- Empty CORS_ORIGIN no longer means "allow any origin".
- ban_cidr / userspace blacklist validate and mask prefixes; CIDR bans are
stored as ranges, so a /24 or /64 ban actually covers the subnet (before,
only the network address was blocked).
Availability:
- ClickHouse client has connect/request timeouts and no mutex held across
await: a hung analytics backend can no longer freeze the ban path. Events
go through a bounded buffer with a drop counter.
- Redis uses a ConnectionManager with per-command timeouts; pubsub and
reconcile reset the backoff after success; publish cannot block shutdown.
- Ban durations from pubsub are clamped and use checked_add; the sync task
survives panics instead of silently dying.
- Blacklist TOCTOU (remove_if) and replace_redis no longer empties the table
during a Redis reconnect.
- RateLimiter and reputation have hard caps with incremental eviction instead
of an unbounded DashMap and a stop-the-world retain.
- The attack detector scores before updating its baseline and needs several
quiet windows to leave UnderAttack, so a sustained flood keeps banning new
offenders instead of ending after one tick.
- accept() backs off on EMFILE/ENFILE, shutdown Err is treated as shutdown,
a global semaphore bounds in-flight connections, rate limiting runs before
PoW, whitelisted IPs are never banned, and connect/handshake/relay have
timeouts with an idle budget.
- PoW uses the configured difficulty as a floor, the clamp is enforced, and
nonce framing survives split segments and coalesced handshake bytes.
- Subnet tracker memory is capped (prefixes and per-prefix sources) and the
monitor bans with the configured TTL.
CI and docs:
- CI runs the test suite with --no-default-features --features protocol-http;
make ebpf fails on errors; the secrets gate catches weak compose defaults.
- doctor skips protected endpoints without a token and exits non-zero on
failure; a drain timeout returns exit code 1.
- TODO §2b records the review findings, what is fixed and what is deferred;
configuration/testing docs describe the new XDP and secret semantics.
96 lines
3.2 KiB
YAML
96 lines
3.2 KiB
YAML
name: CI
|
||
|
||
on:
|
||
push:
|
||
branches: [main]
|
||
pull_request:
|
||
branches: [main]
|
||
workflow_dispatch:
|
||
|
||
env:
|
||
CARGO_TERM_COLOR: always
|
||
RUSTFLAGS: -D warnings
|
||
|
||
jobs:
|
||
rust-check:
|
||
name: Rust — check & clippy
|
||
runs-on: ubuntu-latest
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
- uses: dtolnay/rust-toolchain@stable
|
||
with:
|
||
components: clippy, rustfmt
|
||
- uses: Swatinem/rust-cache@v2
|
||
- run: sudo apt-get update && sudo apt-get install -y libelf-dev libbpf-dev clang linux-libc-dev
|
||
- run: cargo fmt --all --check
|
||
- run: cargo clippy --all-targets --all-features -- -D warnings
|
||
- run: cargo check --all-features
|
||
- run: cargo check --no-default-features --all-targets
|
||
- name: XDP — build binaries
|
||
run: cargo build --features xdp --bins
|
||
- name: XDP — smoke-check BPF compilation (clang)
|
||
run: |
|
||
mkdir -p target/xdp
|
||
# clang with `-target bpf` не смотрит в multiarch-каталог glibc,
|
||
# поэтому asm/types.h из linux/types.h ищем явно.
|
||
clang -O2 -g -target bpf -I"/usr/include/$(gcc -print-multiarch)" \
|
||
-c xdp/core/universal_filter.c -o target/xdp/universal_filter.o
|
||
test -f target/xdp/universal_filter.o
|
||
|
||
rust-test:
|
||
name: Rust — test
|
||
runs-on: ubuntu-latest
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
- uses: dtolnay/rust-toolchain@stable
|
||
- uses: Swatinem/rust-cache@v2
|
||
# libbpf-sys собирает vendored libbpf (нужны libelf/zlib), а build.rs
|
||
# компилирует XDP-программу через clang (нужны libbpf-dev/linux-libc-dev)
|
||
- run: sudo apt-get update && sudo apt-get install -y libelf-dev zlib1g-dev libbpf-dev clang linux-libc-dev
|
||
- run: cargo test --all-features
|
||
|
||
rust-test-no-default-features:
|
||
name: Rust — test (no default features, protocol-http)
|
||
runs-on: ubuntu-latest
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
- uses: dtolnay/rust-toolchain@stable
|
||
- uses: Swatinem/rust-cache@v2
|
||
- run: sudo apt-get update && sudo apt-get install -y libelf-dev zlib1g-dev libbpf-dev clang linux-libc-dev
|
||
# Feature-gated code must actually run: without this job the
|
||
# `--no-default-features` combination is only type-checked, never tested.
|
||
- run: cargo test --no-default-features --features protocol-http
|
||
|
||
repo-gates:
|
||
name: Repo — module size & default secrets
|
||
runs-on: ubuntu-latest
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
- name: Module size gate
|
||
run: bash scripts/check_module_size.sh
|
||
- name: Default secrets gate
|
||
run: bash scripts/check_default_secrets.sh
|
||
|
||
rust-deny:
|
||
name: Rust — cargo-deny
|
||
runs-on: ubuntu-latest
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
- uses: EmbarkStudios/cargo-deny-action@v2
|
||
with:
|
||
command: check
|
||
|
||
docker:
|
||
name: Docker — build edge image
|
||
runs-on: ubuntu-latest
|
||
needs: [rust-test]
|
||
steps:
|
||
- uses: actions/checkout@v4
|
||
- uses: docker/setup-buildx-action@v3
|
||
- name: Build edge
|
||
uses: docker/build-push-action@v6
|
||
with:
|
||
context: .
|
||
file: deploy/docker/Dockerfile.edge
|
||
load: true
|
||
tags: rampart/edge:ci
|