voxelcoreprojects/voxelcore
1
0
Fork 0
mirror of https://github.com/MihailRis/voxelcore.git synced 2026-10-04 18:41:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: optimization: PVS-Studio warning V835

Browse source 
Passing cheap-to-copy arguments by reference can sometimes lead to decreased performance. This change ensures that the argument is passed by value, which is more efficient in cases where the argument is inexpensive to copy.

Reported by: PVS-Studio
Signed-off-by: Vyacheslav Ivanov <islavaivanov76@gmail.com>
This commit is contained in:
Vyacheslav Ivanov 2024-08-02 02:09:15 +03:00 • committed by Pugemon
parent 307ffc3c8f
commit 1bdc9cf759
No known key found for this signature in database
GPG key ID: 472FA343B3CC3287
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/logic/PlayerController.cpp
View file

@ -105,7 +105,7 @@ glm::vec3 CameraControl::updateCameraShaking(const Hitbox& hitbox, float delta)
}
void CameraControl::updateFovEffects(const Hitbox& hitbox,
const PlayerInput& input, float delta) {
PlayerInput input, float delta) {
bool crouch = input.shift && hitbox.grounded && !input.sprint;
float dt = fmin(1.0f, delta * ZOOM_SPEED);
@ -146,7 +146,7 @@ void CameraControl::switchCamera() {
}
}
void CameraControl::update(const PlayerInput& input, float delta, Chunks* chunks) {
void CameraControl::update(PlayerInput input, float delta, Chunks* chunks) {
offset = glm::vec3(0.0f, 0.0f, 0.0f);
if (auto hitbox = player->getHitbox()) {