voxelcoreprojects/voxelcore
1
0
Fork 0
mirror of https://github.com/MihailRis/voxelcore.git synced 2026-10-07 12:01:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: optimization: PVS-Studio warning V813

Browse source 
Passing large objects by const reference avoids unnecessary copying and enhances efficiency.

Reported by: PVS-Studio
Signed-off-by: Vyacheslav Ivanov <islavaivanov76@gmail.com>
This commit is contained in:
Vyacheslav Ivanov 2024-08-02 05:33:32 +03:00 • committed by Pugemon
parent 5b325ac2bc
commit 2c1103307f
No known key found for this signature in database
GPG key ID: 472FA343B3CC3287
42 changed files with 173 additions and 144 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/graphics/core/Batch3D.hpp
View file

@ -27,12 +27,13 @@ class Batch3D : public Flushable {
float r, float g, float b, float a
);
void vertex(
glm::vec3 coord,
const glm::vec3& coord,
float u, float v,
float r, float g, float b, float a
);
void vertex(
glm::vec3 point, glm::vec2 uvpoint,
const glm::vec3& point,
const glm::vec2& uvpoint,
float r, float g, float b, float a
);
void face(
@ -49,12 +50,18 @@ public:
void begin();
void texture(Texture* texture);
void sprite(glm::vec3 pos, glm::vec3 up, glm::vec3 right, float w, float h, const UVRegion& uv, glm::vec4 tint);
void sprite(
const glm::vec3& pos,
const glm::vec3& up,
const glm::vec3& right, float w, float h, const UVRegion& uv,
const glm::vec4& color
);
void xSprite(float w, float h, const UVRegion& uv, const glm::vec4 tint, bool shading=true);
void cube(const glm::vec3 coords, const glm::vec3 size, const UVRegion(&texfaces)[6], const glm::vec4 tint, bool shading=true);
void blockCube(const glm::vec3 size, const UVRegion(&texfaces)[6], const glm::vec4 tint, bool shading=true);
void point(glm::vec3 pos, glm::vec2 uv, glm::vec4 tint);
void point(glm::vec3 pos, glm::vec4 tint);
void point(
const glm::vec3& coord, const glm::vec2& uv, const glm::vec4& tint);
void point(const glm::vec3& coord, const glm::vec4& tint);
void flush() override;
void flushPoints();
};