voxelcoreprojects/voxelcore
1
0
Fork 0
mirror of https://github.com/MihailRis/voxelcore.git synced 2026-10-11 22:11:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

fix: optimization: PVS-Studio warning V836

Browse source 
Expression's value is copied at variable declaration.
The variable is never modified. Consider declaring it as a reference.

Changed variables to be a reference to avoid unnecessary copy.

Reported by: PVS-Studio

Signed-off-by: Vyacheslav Ivanov <islavaivanov76@gmail.com>
This commit is contained in:
Vyacheslav Ivanov 2024-08-01 23:35:13 +03:00 • committed by Pugemon
parent 50a388c539
commit 73e721513c
No known key found for this signature in database
GPG key ID: 472FA343B3CC3287
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/content/ContentLoader.cpp
View file

@ -85,7 +85,7 @@ bool ContentLoader::fixPackIndices(
indexed.push_back(name); indexed.push_back(name);
} }
} }
for (auto name : detected) { for (const auto &name : detected) {
if (!util::contains(indexed, name)) { if (!util::contains(indexed, name)) {
arr->put(name); arr->put(name);
modified = true; modified = true;

2
src/graphics/ui/gui_xml.cpp
View file

@ -203,7 +203,7 @@ static void _readPanel(UiXmlReader& reader, const xml::xmlelement& element, Pane
panel.setMaxLength(element->attr("max-length").asInt()); panel.setMaxLength(element->attr("max-length").asInt());
} }
if (element->has("orientation")) { if (element->has("orientation")) {
auto oname = element->attr("orientation").getText(); const auto &oname = element->attr("orientation").getText();
if (oname == "horizontal") { if (oname == "horizontal") {
panel.setOrientation(Orientation::horizontal); panel.setOrientation(Orientation::horizontal);
} }