voxelcoreprojects/voxelcore
1
0
Fork 0
mirror of https://github.com/MihailRis/voxelcore.git synced 2026-10-04 18:41:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #991 from nogitsune-youkai/vectorFix

Browse source 
Fix exception safety in util::stack_vector::push_back
This commit is contained in:
MihailRis 2026-09-26 22:32:35 +03:00 • committed by GitHub
commit bac0d43fd7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

22
src/util/stack_vector.hpp
View file

@ -48,21 +48,25 @@ namespace util {
} }
void push_back(const T& value) { void push_back(const T& value) {
if (size_ < capacity) { if (size_ >= capacity) {
auto data = reinterpret_cast<char*>(data_.ptr() + (size_++));
new (data) T(value);
} else {
throw std::overflow_error("stack vector capacity exceeded"); throw std::overflow_error("stack vector capacity exceeded");
} }
void* p = data_.data + size_ * sizeof(T);
::new (p) T(value);
++size_;
} }
void push_back(T&& value) { void push_back(T&& value) {
if (size_ < capacity) { if (size_ >= capacity) {
auto data = reinterpret_cast<char*>(data_.ptr() + (size_++));
new (data) T(std::move(value));
} else {
throw std::overflow_error("stack vector capacity exceeded"); throw std::overflow_error("stack vector capacity exceeded");
} }
void* p = data_.data + size_ * sizeof(T);
::new (p) T(std::move(value));
++size_;
} }
void pop_back() { void pop_back() {
@ -76,7 +80,7 @@ namespace util {
void clear() { void clear() {
for (int i = 0; i < size_; ++i) { for (int i = 0; i < size_; ++i) {
data_.ptr()[i].~T(); data_.ptr()[i].~T();
} }
size_ = 0; size_ = 0;
} }