voxelcoreprojects/voxelcore
1
0
Fork 0
mirror of https://github.com/MihailRis/voxelcore.git synced 2026-10-07 12:01:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: optimization: PVS-Studio warning V807

Browse source 
Created references to avoid using repeated expressions, improving performance across multiple instances.

Reported by: PVS-Studio
Signed-off-by: Vyacheslav Ivanov <islavaivanov76@gmail.com>
This commit is contained in:
Vyacheslav Ivanov 2024-08-02 06:07:50 +03:00 • committed by Pugemon
parent 3d21b7ba6a
commit c4cc71623d
No known key found for this signature in database
GPG key ID: 472FA343B3CC3287
4 changed files with 18 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/files/WorldConverter.cpp
View file

@ -73,11 +73,12 @@ std::shared_ptr<Task> WorldConverter::startTask(
[=](){return std::make_shared<ConverterWorker>(converter);},
[=](int&) {}
);
while (!converter->tasks.empty()) {
const convert_task& task = converter->tasks.front();
auto& converterTasks = converter->tasks;
while (!converterTasks.empty()) {
const convert_task& task = converterTasks.front();
auto ptr = std::make_shared<convert_task>(task);
pool->enqueueJob(ptr);
converter->tasks.pop();
converterTasks.pop();
}
pool->setOnComplete([=]() {
converter->write();