From c641a18d32b32c1412ff52fab6655354463b2547 Mon Sep 17 00:00:00 2001 From: MihailRis Date: Wed, 4 Nov 2026 12:43:42 +0300 Subject: [PATCH] fix lighting settings based chunk meshes rebuilding --- src/frontend/screens/LevelScreen.cpp | 18 +++++++++++++++++- src/graphics/render/BlocksRenderer.cpp | 3 ++- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/src/frontend/screens/LevelScreen.cpp b/src/frontend/screens/LevelScreen.cpp index d03416a0b..2f29e8b7d 100644 --- a/src/frontend/screens/LevelScreen.cpp +++ b/src/frontend/screens/LevelScreen.cpp @@ -89,9 +89,25 @@ LevelScreen::LevelScreen( resetChunks(false); frontend->getContentGfxCache().refresh(); })); - keepAlive(settings.graphics.shadowsQuality.observe([=](int quality) { + auto graphics = &settings.graphics; + auto shadowsMeshing = std::make_shared( + graphics->shadowsQuality.get() > 0 && graphics->advancedRender.get() + ); + auto updateShadowsMeshing = [=]() { + bool enabled = + graphics->shadowsQuality.get() > 0 && graphics->advancedRender.get(); + if (enabled == *shadowsMeshing) { + return; + } + *shadowsMeshing = enabled; resetChunks(false); frontend->getContentGfxCache().refresh(); + }; + keepAlive(settings.graphics.shadowsQuality.observe([=](int) { + updateShadowsMeshing(); + })); + keepAlive(settings.graphics.advancedRender.observe([=](bool) { + updateShadowsMeshing(); })); keepAlive(settings.camera.fov.observe([=](double value) { player->fpCamera->setFov(glm::radians(value)); diff --git a/src/graphics/render/BlocksRenderer.cpp b/src/graphics/render/BlocksRenderer.cpp index 14ac0ab15..7fbb09e82 100644 --- a/src/graphics/render/BlocksRenderer.cpp +++ b/src/graphics/render/BlocksRenderer.cpp @@ -696,7 +696,8 @@ SortingMeshData BlocksRenderer::renderTranslucent( void BlocksRenderer::build( const Chunk* chunk, const VoxelsRenderVolume& volume ) { - directionalLightFactor = settings.graphics.shadowsQuality.get() > 0.0f + directionalLightFactor = settings.graphics.shadowsQuality.get() > 0 && + settings.graphics.advancedRender.get() ? 0.0f : DEFAULT_DIRECTIONAL_LIGHT_FACTOR;