voxelcoreprojects/voxelcore
1
0
Fork 0
mirror of https://github.com/MihailRis/voxelcore.git synced 2026-10-07 20:11:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Optimize parameter passing to avoid unnecessary copying

Browse source
This commit is contained in:
Pugemon 2024-06-07 03:58:20 +03:00
parent 46ca1bb04a
commit f25a425cb9
123 changed files with 578 additions and 522 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/world/World.hpp
View file

@ -22,7 +22,7 @@ namespace fs = std::filesystem;
class world_load_error : public std::runtime_error {
public:
world_load_error(std::string message);
world_load_error(const std::string &message);
};
/// @brief holds all world data except the level (chunks and objects)
@ -55,11 +55,11 @@ public:
World(
std::string name,
std::string generator,
fs::path directory,
const fs::path& directory,
uint64_t seed,
EngineSettings& settings,
const Content* content,
std::vector<ContentPack> packs
const std::vector<ContentPack>& packs
);
~World();
@ -90,9 +90,9 @@ public:
/// @param packs vector of all world content-packs
/// @return Level instance containing World instance
static std::unique_ptr<Level> create(
std::string name,
std::string generator,
fs::path directory,
const std::string& name,
const std::string& generator,
const fs::path& directory,
uint64_t seed,
EngineSettings& settings,
const Content* content,
@ -108,7 +108,7 @@ public:
/// @return Level instance containing World instance
/// @throws world_load_error on world.json load error
static std::unique_ptr<Level> load(
fs::path directory,
const fs::path& directory,
EngineSettings& settings,
const Content* content,
const std::vector<ContentPack>& packs