voxelcoreprojects/voxelcore
1
0
Fork 0
mirror of https://github.com/MihailRis/voxelcore.git synced 2026-10-04 10:31:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #995 from nogitsune-youkai/StackVectorExceptionsCppCompliance

Browse source 
Fix: Make clear and pop_back noexcept compliant
This commit is contained in:
MihailRis 2026-09-27 23:14:51 +03:00 • committed by GitHub
commit df057507e9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/util/stack_vector.hpp
View file

@ -69,18 +69,16 @@ namespace util {
++size_; ++size_;
} }
void pop_back() { void pop_back() noexcept {
if (size_ > 0) { if (size_ > 0) {
data_.ptr()[size_ - 1].~T(); data_.ptr()[size_ - 1].~T();
--size_; --size_;
} else { }
throw std::underflow_error("stack vector is empty");
}
} }
void clear() { void clear() noexcept {
for (int i = 0; i < size_; ++i) { for (int i = 0; i < size_; ++i) {
data_.ptr()[i].~T(); data_.ptr()[i].~T();
} }
size_ = 0; size_ = 0;
} }